From 1676909cbf49aff441226f1425603754448618b5 Mon Sep 17 00:00:00 2001 From: Ramiro Paz Date: Tue, 19 May 2026 15:31:39 -0300 Subject: [PATCH] fixes --- src/client/fix/manager.go | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/src/client/fix/manager.go b/src/client/fix/manager.go index 3fbaa20..68a60e6 100644 --- a/src/client/fix/manager.go +++ b/src/client/fix/manager.go @@ -279,10 +279,6 @@ func (m *Manager) handleQuoteAck(msg quoteack.QuoteAck, sessionID quickfix.Sessi err := tracerr.Errorf("handleQuoteAck: quote rejected by TW (quoteReqID=%s, quoteAckStatus=%s, text=%s)", quoteReqID, string(status), text) slog.Error(err.Error()) - m.tradesMu.Lock() - delete(m.trades, quoteReqID) - m.tradesMu.Unlock() - return } @@ -321,9 +317,6 @@ func (m *Manager) handleQuoteResponse(msg quoteresponse.QuoteResponse, sessionID // _TRDSUMM is the final message — clean up the trade. if isTrdSumm { slog.Info("Trade summary received, cleaning up", "quoteReqID", quoteReqID) - m.tradesMu.Lock() - delete(m.trades, quoteReqID) - m.tradesMu.Unlock() } } @@ -362,10 +355,6 @@ func (m *Manager) handleExecutionReport(msg executionreport.ExecutionReport, ses slog.Info("Trade summary received from TW, cleaning up", "execID", execID, "clOrdID", clOrdID, "ordStatus", string(ordStatus), "listID", listID) - m.tradesMu.Lock() - delete(m.trades, clOrdID) - m.tradesMu.Unlock() - case execType == enum.ExecType_TRADE: slog.Info("Trade result received from TW", "execID", execID, "clOrdID", clOrdID, "ordStatus", string(ordStatus), "listID", listID) @@ -421,12 +410,6 @@ func (m *Manager) SendQuote(quoteReqID string, price decimal.Decimal) error { slog.Error(err.Error()) return err } - // if t.Quoted { - // m.tradesMu.Unlock() - // err := tracerr.Errorf("SendQuote: quote already sent for quoteReqID %s", quoteReqID) - // slog.Error(err.Error()) - // return err - // } sessionID := t.SessionID if sessionID == (quickfix.SessionID{}) { @@ -682,11 +665,6 @@ func (m *Manager) loadActiveTrades() error { t.Price = getDecimal(msg.JMessage.Body, "Price") } - case "CW": // QuoteAck — if rejected, trade is dead - if getString(msg.JMessage.Body, "QuoteAckStatus") != string(enum.QuoteAckStatus_ACCEPTED) { - delete(activeTrades, quoteReqID) - } - case "AJ": // QuoteResponse — _TRDSUMM means trade is done (flow 8.6) if strings.HasSuffix(getString(msg.JMessage.Body, "QuoteRespID"), "_TRDSUMM") { delete(activeTrades, quoteReqID)